Subject: | Nice. |
Summary: | Package rating comment |
Messages: | 2 |
Author: | Alekos Psimikakis |
Date: | 2017-10-19 22:50:20 |
|
|
|
Alekos Psimikakis rated this package as follows:
Utility: | Good |
Consistency: | Good |
Documentation: | Good |
|
 Alekos Psimikakis - 2017-10-19 22:50:20
Nice. Good converted size ratios.
Suggestion: The class could also accept the full path of the target image and then break it into path, filename and extension instead of having the caller do that (which I did for the test). E.g.
$a = strrpos($tgt_image,"/"); $path = substr($tgt_image,0,$a);
$b = strrpos($tgt_image,"."); $name = substr($tgt_image,$a+1,$b-$a-1);
$ext = substr($tgt_image,$b+1);
 Juan Chaves - 2017-10-20 08:17:44 - In reply to message 1 from Alekos Psimikakis
Thank you, Alekos! I am glad that you like it, and I appreciate your suggestion. I'll try to build it in as soon as possible.
|